This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Integrate messager facet #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlrocha
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
A few things before we merge:
- I wouldn't expose publicly in the CLI
sendCrossto users as it may be quite confusing. Initially, we are thinking assendCrossto be a function only called by smart contracts in a subnet. This may change in the future, but as we haven't tested it yet, I would keep it "out of sight" for now :) - I think it makes more sense for the argument of
propagateto be acidinstead ofVec<u8>if under the hood we are using acid. I see that in the contract implementation we expect a bytes, maybe we should double check if this is a hash or a cid and do accordingly (the only issue will arise in the interoperability between native and Solidity contracts, as always).
Apart from this, if the e2e lifecycle of subnets and fund/release work we can get this merged.
| } | ||
|
|
||
| async fn whitelist_propagator( | ||
| async fn set_validator_net_addr( |
There was a problem hiding this comment.
hmmm, why is this one not implemented yet? This is something that users currently need, we should get this one implemented (I didn't know this wasn't the case).
There was a problem hiding this comment.
This method is not implemented yet in the contract.
adlrocha
approved these changes
Aug 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate messager facet from the latest solidity contract. Also removing the deprecated whitelist propagator.