This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Feature/subnet lifecycle #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ister, releaseStake, kill in GW feat: implement join, leave, kill, reward method in SA, addStake, register, releaseStake, kill in GW feat: distribute tokens to validators, reentrancy guard chore: interface changes, test cleanup
…op, checkpoint and subnetId helper libraries feat: add commitChildCheck implementation Signed-off-by: Anton Rusev <anton.rusev@limechain.tech> refactor: child checks with nested loop Signed-off-by: Anton Rusev <anton.rusev@limechain.tech> refactor: make getSubnet internal helper function Signed-off-by: Anton Rusev <anton.rusev@limechain.tech> WIP: checkpoint helper library and checkpoint test
…d library feat: add constants and storable message helper feat: simplify subnetId, add helper libraries fix: tests
…nt tests, GW commitChildCheck tests test: add commitChildCheck tests Signed-off-by: Anton Rusev <anton.rusev@limechain.tech> feat: SA commitCheckpoint tests fix: save multiple subnets to the same checkpoint Signed-off-by: Anton Rusev <anton.rusev@limechain.tech>
Signed-off-by: Anton Rusev <anton.rusev@limechain.tech>
arrusev
force-pushed
the
feature/subnet-lifecycle
branch
from
530cccf
to
fe75015
Compare
…p level natspec comments
… cross msg in GW, refactor join method and tests, fix interfaces Signed-off-by: Anton Rusev <anton.rusev@limechain.tech> fix: add one more condition to cross msg in GW Signed-off-by: Anton Rusev <anton.rusev@limechain.tech> refactor: join method fix: join interface, test join calls, GW call on SA reward method feat: fix GW to distribute fees only if fees > 0 Signed-off-by: Anton Rusev <anton.rusev@limechain.tech> fix: reward distribution fix: join method and tests
mikirov
force-pushed
the
feature/subnet-lifecycle
branch
from
4b0a967
to
177836e
Compare
2dpetkov
suggested changes
Mar 10, 2023
bamzedev
suggested changes
Mar 13, 2023
2dpetkov
reviewed
Mar 14, 2023
bamzedev
suggested changes
Mar 15, 2023
2dpetkov
previously approved these changes
Mar 15, 2023
…unit test coverage, interface and file cleanup that misleads coverage, compile time constatnt evaluation feat: refactor join method and formatting, fix helpers, PR comments, add unit test coverage fix: underflow error in SubnetIDHelper when it contains a single route Signed-off-by: Anton Rusev <anton.rusev@limechain.tech> fix: PR comments fix: subnetId helper test: add test coverage for helper libs Signed-off-by: Anton Rusev <anton.rusev@limechain.tech> refactor: interface and file cleanup that misleads coverage refactor: use compile-time expression evaluation instead of hardcoded hashes Signed-off-by: Anton Rusev <anton.rusev@limechain.tech> feat: add SA tests feat: add default Status, cpHelper fuzz tests, cpmHelper tests Signed-off-by: Anton Rusev <anton.rusev@limechain.tech> feat: submit checkpoint tests
2dpetkov
previously approved these changes
Mar 16, 2023
mikirov
force-pushed
the
feature/subnet-lifecycle
branch
from
99bab16
to
7107560
Compare
arrusev
approved these changes
Mar 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Join, leave, kill, commitChildCheck SA methods with their corresponding GW handlers, forge tests for SA and GW for all methods