Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Add messenger facet #171

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Add messenger facet #171

merged 2 commits into from
Aug 3, 2023

Conversation

dnkolegov
Copy link
Contributor

This PR adds a messenger facet.

@aakoshh
Copy link
Contributor

aakoshh commented Aug 3, 2023

Why do you check in .storage-layouts but not the full JSON which includes the ABI?

Copy link
Contributor

@adlrocha adlrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you tested the deployment and it works feel free to merge. Let me know if you need help testing the deployment.

@@ -27,7 +27,6 @@ async function main() {
deployer,
"SubnetActorManagerFacet",
{
AccountHelper: LIBMAP['AccountHelper'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we do not need it after removing isAccount check and the compiler does not compile the code if it sees unnecessary libraries.

@dnkolegov
Copy link
Contributor Author

Why do you check in .storage-layouts but not the full JSON, which includes the ABI?

We use a ready module for this, and it works with files like those. You can think about it like Cargo.lock but for the storage state.

@dnkolegov dnkolegov merged commit 740892d into dev Aug 3, 2023
@dnkolegov dnkolegov deleted the messenger branch August 3, 2023 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants