Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Add install eth-abi to make test #195

Merged
merged 8 commits into from
Sep 1, 2023
Merged

Add install eth-abi to make test #195

merged 8 commits into from
Sep 1, 2023

Conversation

cryptoAtwill
Copy link
Collaborator

@cryptoAtwill cryptoAtwill commented Aug 30, 2023

Some unit tests require eth-abi python module to work. Previously make test assumes eth-abi has already been installed, now we add install eth-abi into make install-dev.

@github-actions
Copy link

Your PR was set to target main. PRs should be target dev.
The base branch of this PR has been automatically changed to dev.
If you really intend to target main, edit the PR.

@github-actions github-actions bot changed the base branch from main to dev August 30, 2023 09:54
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@dnkolegov dnkolegov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Look good!

@dnkolegov dnkolegov merged commit 8e395d8 into dev Sep 1, 2023
5 checks passed
@dnkolegov dnkolegov deleted the eth-abi branch September 1, 2023 12:45
cryptoAtwill added a commit that referenced this pull request Sep 4, 2023
* install eth abi in make test
---------

Co-authored-by: Denis Kolegov <dnkolegov@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants