Implement applyMsg method #31

arrusev · 2023-03-31T08:21:56Z

add applyMsg method that triggers the execution of a cross-subnet message
add system actor validation
optimize the postbox storage

arrusev · 2023-03-31T08:22:10Z

Current dependencies on/for this PR:

main
- PR Implement fund/release methods #22
  - PR Implement crossMsg method #30
    - PR add README.md #36
    - PR Implement applyMsg method #31 👈
      - PR Implement propagate methods #32
        
        PR feat: struct changes #34

This comment was auto-generated by Graphite.

src/constants/Constants.sol

README.md

foundry.toml

src/Gateway.sol

src/SubnetActor.sol

src/interfaces/IGateway.sol

The base branch was changed.

Signed-off-by: Anton Rusev <anton.rusev@limechain.tech>

2dpetkov

Left some comments and nitpicks. And a discussion point.

src/Gateway.sol

src/constants/Constants.sol

test/Gateway.t.sol

src/lib/CrossMsgHelper.sol

Signed-off-by: Anton Rusev <anton.rusev@limechain.tech>

2dpetkov

LGTM! 🚀

adlrocha

Great job! LGTM. Really looking forward to the refactor so we can simplify the code a bit:)

adlrocha · 2023-04-25T08:11:45Z

src/Gateway.sol

    int64 constant DEFAULT_CHECKPOINT_PERIOD = 10;
+
+    /// @notice minimum amount of wei to register a subnet


I guess we should check this once we try to deploy the smart contract in Filecoin, but I don't know how are Filecoin units when sent in a payable transaction considered by the smart contract. Maybe we should use the Filecoin Solidity type for this.

The fevmate library has a WFIL implementation that is an ERC20 with 18 decimals, same as ether. This brings me to the thought that if wrapped FIL has 18 decimals the native one may have 18 as well?

adlrocha · 2023-04-25T08:17:06Z

src/Gateway.sol

+
+        IPCMsgType applyType = crossMsg.message.applyType(networkName);
+
+        if (crossMsg.message.to.subnetId.equals(networkName)) {


Suggested change

if (crossMsg.message.to.subnetId.equals(networkName)) {

// If the cross-message destination is the current network.

if (crossMsg.message.to.subnetId.equals(networkName)) {

adlrocha · 2023-04-25T08:17:29Z

src/Gateway.sol

+
+            return crossMsg.execute();
+        }
+


Suggested change

// when the destination is not the current network we add it to the postbox for further propagation

adlrocha · 2023-04-25T08:21:20Z

src/Gateway.sol

+    function _bottomUpStateTransition(
+        StorableMsg calldata storableMsg
+    ) internal {
+        if (


I forgot how horrible this piece of code was 🤦 This will be significantly simplified after the refactor. The behavior is the same as with top-down messages where there is a unique nonce for each cross-net message, and for each subnet (instead of having to aggregate them as we do now)

Signed-off-by: Anton Rusev <anton.rusev@limechain.tech>

mikirov

LGTM

2dpetkov

beautiful :)

This was referenced Mar 31, 2023

Implement crossMsg method #30

Merged

Implement fund/release methods #22

Merged

arrusev mentioned this pull request Mar 31, 2023

Implement propagate methods #32

Merged

mikirov force-pushed the feature/method-apply-msg branch from d307b4b to b893dcd Compare April 3, 2023 07:43

arrusev force-pushed the feature/method-apply-msg branch from b893dcd to cbe1b3c Compare April 4, 2023 08:03

arrusev force-pushed the feature/cross-msg branch from 5e12e69 to 7f68583 Compare April 4, 2023 10:09

arrusev force-pushed the feature/method-apply-msg branch from cbe1b3c to 886adf6 Compare April 4, 2023 10:09

mikirov force-pushed the feature/cross-msg branch from 7f68583 to 5e12e69 Compare April 4, 2023 12:10

mikirov force-pushed the feature/method-apply-msg branch from 886adf6 to cbe1b3c Compare April 4, 2023 12:10

arrusev force-pushed the feature/cross-msg branch from 5e12e69 to 2b027ec Compare April 5, 2023 10:27

arrusev force-pushed the feature/method-apply-msg branch from cbe1b3c to f0609fc Compare April 5, 2023 10:27

mikirov force-pushed the feature/cross-msg branch from 2b027ec to 7fafeec Compare April 6, 2023 05:50

mikirov force-pushed the feature/method-apply-msg branch from f0609fc to b6fe533 Compare April 6, 2023 05:50

arrusev force-pushed the feature/cross-msg branch from 7fafeec to 2b027ec Compare April 7, 2023 08:25

arrusev force-pushed the feature/method-apply-msg branch from b6fe533 to f0609fc Compare April 7, 2023 08:25

mikirov force-pushed the feature/cross-msg branch from 2b027ec to d0153c2 Compare April 7, 2023 12:10

mikirov force-pushed the feature/method-apply-msg branch 2 times, most recently from d94ac57 to 67b5a3b Compare April 9, 2023 20:23

mikirov mentioned this pull request Apr 9, 2023

feat: struct changes #34

Closed

arrusev force-pushed the feature/method-apply-msg branch 6 times, most recently from 9aff9d6 to 2c22b6f Compare April 12, 2023 07:31

2dpetkov mentioned this pull request Apr 12, 2023

add README.md #36

Merged

arrusev force-pushed the feature/method-apply-msg branch from 2c22b6f to 9660fa9 Compare April 12, 2023 14:54

2dpetkov reviewed Apr 13, 2023

View reviewed changes

src/constants/Constants.sol Show resolved Hide resolved

mikirov force-pushed the feature/cross-msg branch from e156af9 to 59751b0 Compare April 19, 2023 17:07

arrusev force-pushed the feature/method-apply-msg branch from 694e214 to b3cdf37 Compare April 20, 2023 08:55

mikirov requested review from mikirov and 2dpetkov April 20, 2023 10:55

mikirov self-assigned this Apr 20, 2023

mikirov previously approved these changes Apr 20, 2023

View reviewed changes

2dpetkov reviewed Apr 20, 2023

View reviewed changes

arrusev changed the base branch from main to feature/cross-msg April 21, 2023 07:30

arrusev changed the base branch from feature/cross-msg to main April 21, 2023 07:31

chore: fix comment, remove memory alloc

be94c69

Signed-off-by: Anton Rusev <anton.rusev@limechain.tech>

2dpetkov self-requested a review April 21, 2023 09:48

2dpetkov reviewed Apr 21, 2023

View reviewed changes

arrusev added 2 commits April 24, 2023 09:45

feat: storage alloc, fix comment, logic reorder

a636d00

Signed-off-by: Anton Rusev <anton.rusev@limechain.tech>

refactor: use method signature instead of method number

0dae87d

Signed-off-by: Anton Rusev <anton.rusev@limechain.tech>

2dpetkov self-requested a review April 24, 2023 11:38

2dpetkov previously approved these changes Apr 24, 2023

View reviewed changes

mikirov previously approved these changes Apr 24, 2023

View reviewed changes

2dpetkov requested a review from adlrocha April 25, 2023 07:04

adlrocha previously approved these changes Apr 25, 2023

View reviewed changes

refactor: simplify postbox

115e296

Signed-off-by: Anton Rusev <anton.rusev@limechain.tech>

arrusev dismissed stale reviews from adlrocha, mikirov, and 2dpetkov via 115e296 April 25, 2023 09:52

arrusev requested review from mikirov, adlrocha and 2dpetkov April 25, 2023 12:39

mikirov approved these changes Apr 25, 2023

View reviewed changes

2dpetkov approved these changes Apr 25, 2023

View reviewed changes

arrusev merged commit 08adebe into main Apr 26, 2023

dnkolegov deleted the feature/method-apply-msg branch June 27, 2023 11:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement applyMsg method #31

Implement applyMsg method #31

arrusev commented Mar 31, 2023 •

edited

Loading

arrusev commented Mar 31, 2023 •

edited

Loading

2dpetkov left a comment

2dpetkov left a comment

adlrocha left a comment

adlrocha Apr 25, 2023

mikirov Apr 25, 2023 •

edited

Loading

adlrocha Apr 25, 2023 •

edited

Loading

adlrocha Apr 25, 2023

adlrocha Apr 25, 2023

mikirov left a comment

2dpetkov left a comment

		int64 constant DEFAULT_CHECKPOINT_PERIOD = 10;

		/// @notice minimum amount of wei to register a subnet


		IPCMsgType applyType = crossMsg.message.applyType(networkName);

		if (crossMsg.message.to.subnetId.equals(networkName)) {

	if (crossMsg.message.to.subnetId.equals(networkName)) {
	// If the cross-message destination is the current network.
	if (crossMsg.message.to.subnetId.equals(networkName)) {


	// when the destination is not the current network we add it to the postbox for further propagation

Implement applyMsg method #31

Implement applyMsg method #31

Conversation

arrusev commented Mar 31, 2023 • edited Loading

arrusev commented Mar 31, 2023 • edited Loading

2dpetkov left a comment

Choose a reason for hiding this comment

2dpetkov left a comment

Choose a reason for hiding this comment

adlrocha left a comment

Choose a reason for hiding this comment

adlrocha Apr 25, 2023

Choose a reason for hiding this comment

mikirov Apr 25, 2023 • edited Loading

Choose a reason for hiding this comment

adlrocha Apr 25, 2023 • edited Loading

Choose a reason for hiding this comment

adlrocha Apr 25, 2023

Choose a reason for hiding this comment

adlrocha Apr 25, 2023

Choose a reason for hiding this comment

mikirov left a comment

Choose a reason for hiding this comment

2dpetkov left a comment

Choose a reason for hiding this comment

arrusev commented Mar 31, 2023 •

edited

Loading

arrusev commented Mar 31, 2023 •

edited

Loading

mikirov Apr 25, 2023 •

edited

Loading

adlrocha Apr 25, 2023 •

edited

Loading