Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): new observability bottom up tracing/metrics #1061

Merged
merged 40 commits into from
Jul 22, 2024
Merged

feat(node): new observability bottom up tracing/metrics #1061

merged 40 commits into from
Jul 22, 2024

Conversation

karlem
Copy link
Contributor

@karlem karlem commented Jul 9, 2024 •
edited
Loading

Close #1056

@karlem karlem changed the base branch from main to new-observability July 9, 2024 17:10
@karlem karlem force-pushed the new-observability-bottom-up branch 2 times, most recently from 45e4e41 to 85176fe Compare July 12, 2024 11:55
@karlem karlem requested a review from cryptoAtwill July 12, 2024 11:55
@karlem karlem marked this pull request as ready for review July 12, 2024 12:08
@karlem karlem changed the title Introduce New Observability Top-Down Tracing/Metrics Events Introduce New Observability Bottom Up Tracing/Metrics Events Jul 12, 2024
@karlem karlem force-pushed the new-observability-bottom-up branch 2 times, most recently from 5c43582 to a627c3e Compare July 17, 2024 12:07
@karlem karlem requested a review from raulk July 17, 2024 12:07
@karlem karlem changed the title Introduce New Observability Bottom Up Tracing/Metrics Events feat(node): Introduce New Observability Bottom Up Tracing/Metrics Events Jul 17, 2024
@karlem karlem changed the title feat(node): Introduce New Observability Bottom Up Tracing/Metrics Events feat(node): new observability bottom up tracing/metrics Jul 17, 2024
@karlem karlem force-pushed the new-observability-bottom-up branch from a627c3e to 3d5b48d Compare July 18, 2024 22:20
Base automatically changed from new-observability to main July 19, 2024 13:41
@karlem karlem force-pushed the new-observability-bottom-up branch from e8fe0c2 to 8b938d4 Compare July 19, 2024 14:50
@karlem
Copy link
Contributor Author

karlem commented Jul 19, 2024 •
edited
Loading

Thanks for the review @raulk. I have address all the issues mentioned above. I have also fixed couple of things that we have missed in the previous PR. (eg. removing unused code & registering the metrics)

raulk
raulk approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're good to merge 🎉

@karlem karlem merged commit ed437af into main Jul 22, 2024
20 checks passed
@karlem karlem deleted the new-observability-bottom-up branch July 22, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptoAtwill cryptoAtwill cryptoAtwill approved these changes

@raulk raulk raulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
IPC Core Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce new observibility - Emit Bottom-Up Traces
3 participants
@karlem @raulk @cryptoAtwill