Topdown Enhancement: Process vote quorum #1070
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2024
added 4 commits
July 18, 2024 21:22
…pyard/ipc into process-vote-quorum
…pyard/ipc into process-vote-quorum
…pyard/ipc into process-vote-quorum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1086, this PR adds quorum cert checking to the abci
process.This PR removes cache checking in abci
process, as long as the quorum cert is validate against the current validator set, the quorum cert is accepted.This addresses a few issues raised previously:
processshould now be deterministic. Previously, if the node hasprocesstrue to a proposal, but then crashes, it is likely the node willprocessfalse if the vote is replayed due to in memory cache missing upon restart. This eliminates the need to rely on in memory cache as all the data needed is stored in the txn.