Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prefix metrics with "ipc" #1172

Merged
merged 2 commits into from
Oct 15, 2024
Merged

feat: prefix metrics with "ipc" #1172

merged 2 commits into from
Oct 15, 2024

Conversation

karlem
Copy link
Contributor

@karlem karlem commented Oct 14, 2024

Close #1152

@karlem karlem requested a review from a team as a code owner October 14, 2024 15:49
raulk
raulk approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the user and design docs, please.

@karlem karlem merged commit 6d7402f into main Oct 15, 2024
15 checks passed
@karlem karlem deleted the prefix-metrics branch October 15, 2024 11:20
@karlem karlem mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulk raulk raulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
IPC Core Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metric name preface string
2 participants
@karlem @raulk