Several improvements to deploy subnet script #874
Conversation
fridrik01
force-pushed
the
improve-deployment-script
branch
3 times, most recently
from
4f3efdc to
5e1791d
Compare
| echo "Removing existing .ipc folder" | ||
| rm -rf ~/.ipc |
There was a problem hiding this comment.
This seems a bit brutal. Should it perhaps make a backup, if it doesn't exist yet?
There was a problem hiding this comment.
Just wondering: if you have this nice toml CLI, could it not upsert the setting of the specific subnet which is /r314159, rather than deleting everything the user had potentially configured?
There was a problem hiding this comment.
This seems a bit brutal. Should it perhaps make a backup, if it doesn't exist yet?
Maybe call it reset_local_.sh and/or add a prompt to confirm to user that it will reset your ipc folder?
There was a problem hiding this comment.
The upsert trick from @aakoshh would work for the ipc-cli, but this folder is also storing validator config and keys. @fridrik01 alternatively create a timestamped folder?
fridrik01
force-pushed
the
improve-deployment-script
branch
from
8f78f53 to
fed218a
Compare
raulk
changed the title
There was a problem hiding this comment.
Pinged @fridrik01 for action here.
How are we planning to move this PR forward? I think we've established that rm'ing the .ipc folder is undesirable. Can we rotate it instead? (I liked @aakoshh’s suggestion, but it only solves part of the problem.)
fridrik01
force-pushed
the
improve-deployment-script
branch
from
d06ecd9 to
9841ec3
Compare
|
@raulk I updated the PR so it renames the ipc folder (to include a timestamp) when the script runs so nothing gets deleted |
- Fix relayer not starting due to missing argument - Fix bug when default-key was first in the json array - Streamline local deployment by introducing a prepare_local.sh script - Improve documentation for local deployment and document more known issues
Co-authored-by: Jorge M. Soares <547492+jsoares@users.noreply.github.com>
fridrik01
force-pushed
the
improve-deployment-script
branch
from
a6f7583 to
7646278
Compare
Closes ENG-849
Closes ENG-857