-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(specs): Subnet Lifecycle #895
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,68 @@ | |||
# Subnet Lifecycle | |||
A subnet is a new subsystem that a user can spawn from a parent subnet in a permissionless and on-demand way, depending on scalability requirements. Subnets have separate consensus algorithms and cryptoeconomic rules from their parent subnet. Subnets are firewalled from the parent network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A subnet is a new subsystem that a user can spawn from a parent subnet
Recursive definition. I guess this should mention that subnet is a chain of its own, and one can think of a subnet as an LN+1
connected to a LN
chain, eg L2
is connected to L1
.
Subnets are firewalled from the parent network.
Is "parent network" different from "parent subnet"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I think it's best to name them the same to avoid confusion. As this is the spec, it should be very dry and precise, IMO.
# Subnet Lifecycle | ||
A subnet is a new subsystem that a user can spawn from a parent subnet in a permissionless and on-demand way, depending on scalability requirements. Subnets have separate consensus algorithms and cryptoeconomic rules from their parent subnet. Subnets are firewalled from the parent network. | ||
|
||
Subnets begin with a chosen "rootnet". In case of L2 subnets, “rootnets” refer to a layer 1 blockchain, such as Filecoin or Ethereum. Child subnets are spawned from the rootnet and the rootnet becomes the parent subnet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subnets begin with a chosen "rootnet".
Parent subnet, parent network, rootnet – are these all the same concept? Maybe it makes sense to have a Glossary? eg take a look at https://fluence.dev/docs/build/glossary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I can raise this to the team. But here rootnet
simply means the parent
of all, like the starting subnet, which for the sake of recurrence.
|
||
Each subnet can have any number of child subnets, while each child subnet only has one parent subnet. Subnets can scale infinitely, to layer 2 and beyond. A single hierarchy tree begins at the chosen rootnet. | ||
|
||
Subnets within a single hierarchy tree have native communication protocols and are able to transfer assets and state without a custom bridge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have native communication protocols
Between which parties? I guess it's between all the subnets (parents, children, etc), I guess makes sense to point out what exactly these native communication protocols unite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is the communication does not really have to be specified in the spec, up to the implementation.
spec/subnets-lifecycle.md
Outdated
|
||
The lifecycle of a subnet begins when it’s deployed and ends when the subnet is closed. | ||
|
||
Before a subnet is created, one must specify the validator power allocation mode, which is called the `PermissionMode`. There are three kinds of permission mode at the moment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "created" the same as "deployed", or these are different phases of the lifecycle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, good point. What do you mean by deploy
? But what the above means is the subnet actor is deployed.
spec/subnets-lifecycle.md
Outdated
|
||
Before the minimal requirements are met, the subnet is in a `preBootstrap` state, once those conditions are met, the subnet is in a `postBootstap` state. Any operations performed on the subnet in `preBootstrap` state is recorded in the subnet `genesis`. | ||
|
||
For normal users, they can perform: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is a normal user? Is it a Validator that's not an Owner, or just a 3rd party who has a wallet in the subnet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3rd party who has a wallet in the subnet. I will rephrase this a little.
spec/subnets-lifecycle.md
Outdated
|
||
For normal users, they can perform: | ||
|
||
- Prefund: Provide genesis balance to the subnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to elaborate a bit on who usually does that and why
spec/subnets-lifecycle.md
Outdated
For normal users, they can perform: | ||
|
||
- Prefund: Provide genesis balance to the subnet | ||
- Fund: Send fund from the parent to an address in the child subnet. The parent will track the total circulating supply of the subnet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it's about moving some of the child subnet's native token from parent to child? Maybe it makes sense to mention that Parent and Child might have different notion of "fund", ie different native token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be covered in the SupplySource
section. I will add a link to that.
|
||
### Deployment | ||
|
||
For ipc powered subnet, it’s deployed through `SubnetRegistry`. This contract should be deployed together with the gateway. One can simply call [newSubnetActor](https://github.com/consensus-shipyard/ipc/blob/7af25c4c860f5ab828e8177927a0f8b6b7a7cc74/contracts/src/subnetregistry/RegisterSubnetFacet.sol#L22) method to deploy a new subnet under the gateway contract. But do note that this method requires permission. The creator of this registry could limit the access on who can deploy new subnets or there are no restrictions at all, see [line](https://github.com/consensus-shipyard/ipc/blob/7af25c4c860f5ab828e8177927a0f8b6b7a7cc74/contracts/src/subnetregistry/RegisterSubnetFacet.sol#L95). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ipc powered subnet
Are there any other options? If yes, maybe mention that subnet abstracts away the implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently we only have IPC implementation, but as long as the interface is aligned, it should be ok
|
||
For `Collateral` permission mode, validators’ stake can be updated and is directly reflected in the validator’s genesis weight until the subnet is bootstrapped. However, for `Federated` permission mode, the owner must make sure the minimum number of validators are met, see [check](https://github.com/consensus-shipyard/ipc/blob/7af25c4c860f5ab828e8177927a0f8b6b7a7cc74/contracts/src/lib/LibSubnetActor.sol#L82). | ||
|
||
The child subnet blockchain, i.e. fendermint, can query the parent subnet actor to [obtain](https://github.com/consensus-shipyard/ipc/blob/7af25c4c860f5ab828e8177927a0f8b6b7a7cc74/fendermint/app/src/cmd/genesis.rs#L33) the genesis information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So subnet has "blockchain" and something else? Maybe makes sense to elaborate on what constitutes a Subnet then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean just the subnet actor and the blockchain.
|
||
The subnet is bootstrapped once the minimal validator requirement and, for `Collateral` permission mode, the minimal collateral requirement, are met. | ||
|
||
The `bootstrapped` state of the subnet will become `true` and the `genesis` of the subnet will now be immutable. One need to note that once the subnet is bootstrapped, the `SubnetActor` will [register](https://github.com/consensus-shipyard/ipc/blob/7af25c4c860f5ab828e8177927a0f8b6b7a7cc74/contracts/src/gateway/GatewayManagerFacet.sol#L33) itself to the corresponding gateway contract. The `SubnetActor` will transfer its fund to the gateway and the gateway will manage the funds for each registered subnet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
bootstrapped
state of the subnet will becometrue
So there's a preBootstrap
state, postBootstrap
state and bootstrapped: true
? That's 3 or 2 states? Also I guess there should be a Closed
state or something like that.
Maybe it makes sense to start this article by enumerating possible state and some transition arrows? i.e. ASCII or Mermaid state diagram.
|
||
### **Closing a Subnet** | ||
|
||
The conditions for closing a subnet are as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who can initiate a subnet closure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently there is no permission required if all validators have left the subnet
spec/subnets-lifecycle.md
Outdated
|
||
- A child subnet cannot be killed until its circulating supply is zero, which can be achieved when all users send their funds back to a parent. | ||
- If all validators leave a subnet even when there are still users of the subnet, the users will have to either run their own validator or wait for a validator to return to the subnet. | ||
- If a bug causes the subnet to fail, there is no way to recover funds in the subnet without a valid checkpoint signed by the latest validator committee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it related to closing a subnet, or just a general consideration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general consideration
Co-authored-by: folex <0xdxdy@gmail.com>
Co-authored-by: folex <0xdxdy@gmail.com>
Co-authored-by: folex <0xdxdy@gmail.com>
@folex I have updated the doc according to you feedback. Some parts I left as it is and explained as replies to the PR, please help take a look. |
Adding the doc for subnet lifecycle.