Add RPC client #103
Add RPC client #103
Conversation
chain/consensus/mir/rpc/rpc.go
Outdated
| } | ||
|
|
||
| func (c *JSONRPCClient) SendRequest(method string, params interface{}, reply interface{}) error { | ||
| paramBytes, err := rpc.EncodeClientRequest(method, params) |
There was a problem hiding this comment.
Are we sure that the method an parameters generated from this package are compatible with our implementation in the IPC agent?
There was a problem hiding this comment.
Yes, I asked @cryptoAtwill to create a string-based test in the JSON RPC server repo. Then I can use the same strings (serialized requests) to test them here.
Do you have other ideas?
There was a problem hiding this comment.
This works for now, just to double-check before we get integration tests ready.
chain/consensus/mir/rpc/rpc.go
Outdated
| return fmt.Errorf("received status code: %d", resp.StatusCode) | ||
| } | ||
|
|
||
| if err := rpc.DecodeClientResponse(resp.Body, reply); err != nil { |
There was a problem hiding this comment.
Same here, we should ensure that is compatible with our implementation.
| // GetValidatorSet gets the membership config from the actor state. | ||
| func (c *ActorMembership) GetValidatorSet() (*Set, error) { | ||
| var set Set | ||
| err := c.client.SendRequest("Filecoin.GetValidatorSet", nil, &set) |
There was a problem hiding this comment.
This is wrong, the method name is the following: https://github.com/consensus-shipyard/ipc-agent/blob/5815f5955c1eaaf4bf07637e460cfbcee1f2bdf4/src/config/server.rs#L20
This PR adds a JSON RPC client to request IPC Agent, adds support for onchain reconfiguration, adds a basic test to check that onchain reconfiguration can be received via a stub JSOn RPC client, adapts CLI.