Hypercore v1 #5
Open
Hypercore v1 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be ready to be looked at. Gonna get started on the general "Group" abstraction that will make it easy to spin up groups and control membership within them. After that I'll put together an example using this tech. |
|
|
||
| constructor ({ | ||
| id = randomBytes(8).toString('hex'), | ||
| initiator = id | ||
| initiator = id, | ||
| loadFeed = defaultFeedLoader |
There was a problem hiding this comment.
Looking over the code the name loadFeed has been sticking out to me: As a developer using this API: what am I supposed to do? In the current case its like getOrLoadFeed if I understand it correctly but I was wondering if maybe reqestFeed may be appropriate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
HypercoreFeedclasses using hyper-sdk@consento-org/maintainer