Fix incorrect annotation name #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VasekPurchart
force-pushed
the
fix-doctrine-annotations-loading
branch
from
2fd8ecf to
496d2e0
Compare
VasekPurchart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the dependency is
doctrine/orm: ^2.6.3then highest depdenencies builds are failing, but lowest dependencies are okay: https://github.com/consistence/consistence-doctrine/actions/runs/4026729820With
doctrine/orm: 2.14(locked) everything is failing: https://github.com/consistence/consistence-doctrine/actions/runs/4026706740 .With
doctrine/orm: 2.13.5(locked) everything is OK: https://github.com/consistence/consistence-doctrine/actions/runs/4026766351 .Based on that I have isolated the break to doctrine/orm#10321 , which was introduced in
2.14. If I update my local vendor on2.14with reverted changes from this PR, then everything starts working again.The fact, that it was not working only for
@Doctrine\ORM\Mapping\MappedSuperClass, but for everything else it did, led me to guessing that this is an autoloading issue and indeed it was.