mintty read_key fails with "Incorrect function"

[EdenEast]

use console::Term;
fn main() {
    let term = Term::stdout();
    let result = term.read_key();
    match result {
        Ok(k) => println!("Key: {:?}", k),
        Err(e) => println!("Error: {:?}", e),
    };
}

Running this code using mintty. Ran this code using msys and mingw. When running though the integrated terminal in visual studio code the code passes. When running it on mintty it fails with the line

Error: Os { code: 1, kind: Other, message: "Incorrect function." }

[mitsuhiko]

I would need help tracking this down. I'm not using mintty myself.

[MichaelMcDonnell]

This issue is the root cause of mitsuhiko/insta#79.

[MichaelMcDonnell]

It's the call to ReadConsoleInputW in the read_key_event function in the file windows_term.rs that fails. I tried adding a println! inside the branch that handles success being 0, and that's the last thing I see before the error message.

Maybe the problem is that windows_term is used instead of unix_term? Just saw that windows_termalso handles MSYS.

[MichaelMcDonnell]

The root cause seems to be mintty/mintty#906?

[mitsuhiko]

I wonder if the msys detection does not work here. This is how we detect msys currently: https://github.com/mitsuhiko/console/blob/d35ce3e524106bb3c05e9747c8e41408bc073663/src/windows_term.rs#L334-L362

[MichaelMcDonnell]

The code seems correct to me? I printed the name and got \msys-1888ae32e00d56aa-pty0-to-master. The function msys_tty_on returns true. That is what is expected right?

UPDATE: Forgot to mention I'm running C:\Program Files\Git\bin\git-bash.exe, so it might work differently. Btw. if I run bash straight from C:\Program Files\Git\bin\bash.exe then it works fine.

[MichaelMcDonnell]

It seems like git-bash.exe is redirecting the standard input. I added the following lines in get_stdin_handle:

let file_type = unsafe { winapi::um::fileapi::GetFileType(handle) };
println!("file_type is {}", file_type);

It prints 3 when I use git-bash.exe and 2 when I use bash.exe or cmd.exe. The three is FILE_TYPE_PIPE which means the input has been redirected. Maybe the ReadConsoleInput function doesn't work with redirected input?

[mitsuhiko]

Would be happy to merge a fix if someone has one. I'm not using git-bash myself.

[rafamerlin]

So, one workaround that should work on mingw64 is to use winpty.

So let's say the app you have which uses this library is called test

So you run winpty test + any arguments
If you want to keep it permanent you can just create an alias in .bashrc file and you can just call it directly.

[mitsuhiko]

I would still like to fix this issue but as mentioned I do not use mintty. If someone is, help would really be appreciated here.

[Lemminkyinen]

I would still like to fix this issue but as mentioned I do not use mintty. If someone is, help would really be appreciated here.

I am occasionally using git-bash.exe and with it "Incorrect function" error is happening. What information would help you to fix the issue?

TERM: xterm, MSYSTEM: "MINGW64"