Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #612
Note that I have to eat my words. This PR does not use the approach that @djc suggested:
I tried to do that, but I ran into trouble here:
indicatif/src/draw_target.rs
Line 390 in 8941d5e
That is,
DrawStateWrapper
's drop handler usesstate.orphan_lines_count
as a number ofstate.lines
entries, and I couldn't see a good way around that. So I adapted the other parts of the code to use the same approach.This PR currently has five commits. I think they should make sense indiviudally.