Skip to content
This repository has been archived by the owner on Mar 6, 2020. It is now read-only.

go1.8 and gb test with latest release (v0.4.3) do not play nice. #690

Closed
freeformz opened this issue Feb 17, 2017 · 2 comments
Closed

go1.8 and gb test with latest release (v0.4.3) do not play nice. #690

freeformz opened this issue Feb 17, 2017 · 2 comments

Comments

@freeformz
Copy link
Contributor

It fails with something like:

Given this fixture from the heroku buildpack I get this when using gb @ v0.4.3:

$ gb test
# cmd/fixture/testmain
_testmain.go:48: cannot use matchString (type func(string, string) (bool, error)) as type testing.testDeps in argument to testing.MainStart:
	func(string, string) (bool, error) does not implement testing.testDeps (missing MatchString method)
# sub/testmain
_testmain.go:56: cannot use matchString (type func(string, string) (bool, error)) as type testing.testDeps in argument to testing.MainStart:
	func(string, string) (bool, error) does not implement testing.testDeps (missing MatchString method)
FATAL: command "test" failed: exit status 2

This does not happen when I checkout master, recompile gb and re-run the tests.

Can we get a new release?

@davecheney
Copy link
Contributor

I think this is fixed with #692. Please reopen if this is not the case. A test case was added to the integration test suite based on the sample code in the error report.

@freeformz
Copy link
Contributor Author

Thanks, can I get a new release ? That was my main concern, to have a released version that supports go1.8. Thanks for all of your work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants