This repository has been archived by the owner on Mar 6, 2020. It is now read-only.
remove old go1.8 NoGoError code #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gb#690
davecheney
force-pushed
the
fixedbugs/690
branch
from
fce658d to
b818264
Compare
|
@freeformz i'm going to commit this to fix #690. I grabbed the test fixture from the bug report and it passes fine on all versions of Go from 1.4 to tip. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the since rolled back change to build.NoGoError Go 1.8+ workaround.
Fixes gb#690