Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMS verification consistency #1832

Merged
merged 1 commit into from
Sep 6, 2017
Merged

SMS verification consistency #1832

merged 1 commit into from
Sep 6, 2017

Conversation

voodoorai2000
Copy link
Member

What

  • Checks sms verification in a more consistent way

How

  • Calling method sms_verified? instead of db attribute confirmed_phone

Why

  • To make it easier to skip sms verification by just setting to true the return value of method sms_verified?

Test

  • Not needed

Deployment

  • As usual

Warnings

  • None

bertocq
bertocq approved these changes Sep 6, 2017
View reviewed changes
Copy link
Collaborator

@bertocq bertocq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bertocq bertocq merged commit f5f64f5 into master Sep 6, 2017
@bertocq bertocq deleted the verification-consistency branch September 6, 2017 19:46
@bertocq bertocq mentioned this pull request Sep 8, 2017
Merged
javierm pushed a commit to javierm/consul that referenced this pull request Mar 6, 2019
@decabeza
Merge pull request consuldemocracy#1832 from AyuntamientoMadrid/budge…
1bf3664 
…t-text

Update budgets confirm group es translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertocq bertocq bertocq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voodoorai2000 @bertocq