Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is broken with go 1.16 #471

Open
gnufied opened this issue Mar 3, 2021 · 2 comments
Open

Build is broken with go 1.16 #471

gnufied opened this issue Mar 3, 2021 · 2 comments

Comments

@gnufied
Copy link
Contributor

gnufied commented Mar 3, 2021

We don't have to fix this right away but it looks like builds might be broken in 1.16 because of go module changes.

(cd /home/hekumar/goal/src/github.com/golang/protobuf/ && go get -v -d $(go list -f '{{ .ImportPath }}' ./...)) &&
go build -o "protoc-gen-go" github.com/golang/protobuf/protoc-gen-go
no required module provides package github.com/golang/protobuf/protoc-gen-go: working directory is not part of a module
make[1]: *** [Makefile:66: protoc-gen-go] Error 1
make[1]: Leaving directory '/home/hekumar/goal/src/github.com/container-storage-interface/spec/lib/go'
make: *** [Makefile:36: build] Error 2

@gnufied
Copy link
Contributor Author

gnufied commented Mar 3, 2021

it works by explicitly disabling go modules though:

GO111MODULE=off make

@jdef
Copy link
Member

jdef commented Mar 4, 2021 via email

huww98 added a commit to huww98/csi-spec that referenced this issue Oct 1, 2023
update protoc to v24.3
update protoc-gen-go to v1.31.0
added protoc-gen-go-grpc at v1.3.0

restruct the makefile to use "go install" to install tools
use extended regular expressions in sed command

Fixes build on arm OSX host
Fixes container-storage-interface#471
huww98 added a commit to huww98/csi-spec that referenced this issue Oct 1, 2023
updated protoc to v24.3
updated protoc-gen-go to v1.31.0
added protoc-gen-go-grpc at v1.3.0

Modified the makefile to use "go install" to install tools.
Use extended regular expressions in "sed" command.

Fixes build on arm OSX host
Fixes container-storage-interface#471
huww98 added a commit to huww98/csi-spec that referenced this issue Oct 2, 2023
updated protoc to v24.3
updated protoc-gen-go to v1.31.0
added protoc-gen-go-grpc at v1.3.0

Modified the makefile to use "go install" to install tools.
Use extended regular expressions in "sed" command.

Fixes build on arm OSX host
Fixes container-storage-interface#471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants