-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeleteVolumeRequest:A parameter must be added to transfer the PV name of the volume to be deleted #558
Comments
Volume ID must be unique across all vols of the SP. It sounds like that
guarantee was not met. Also, k8s APIs questions should be fielded by k8s
SIG storage, not here.
…On Tue, Dec 5, 2023, 9:46 AM redriverhong ***@***.***> wrote:
Is your feature request related to a problem?/Why is this needed
Currently, the DeleteVolumeRequest is only one parameter VolumeId, which
is used to transfer the volume to be deleted. However, this requirement
cannot be met in the scenario where PV volumes are preset.
image.png (view on web)
<https://github.com/container-storage-interface/spec/assets/11647782/e96ad51e-9b48-4996-bbbe-aea12761e737>
for example:
apiVersion: v1
kind: PersistentVolume
metadata:
annotations:
pv.kubernetes.io/provisioned-by: com.localcsi
pv.kubernetes.io/create-by: manual // Identifier Manually Preset
name: pv-test-0
spec:
capacity:
storage: 256Mi
accessModes:
- ReadWriteOnce
claimRef:
apiVersion: v1
kind: PersistentVolumeClaim
name: data-test-0
namespace: default
persistentVolumeReclaimPolicy: Retain
volumeMode: Filesystem
storageClassName: local
csi:
driver: com.localcsi
fsType: ext4
volumeHandle: caasvg_lv // volumeId
nodeAffinity:
required:
nodeSelectorTerms:
- matchExpressions:
- key: kubernetes.io/hostname
operator: In
values:
- master1
------------------------------
apiVersion: v1
kind: PersistentVolume
metadata:
annotations:
pv.kubernetes.io/provisioned-by: com.localcsi
pv.kubernetes.io/create-by: manual // Identifier Manually Preset
name: pv-test-1
spec:
capacity:
storage: 256Mi
accessModes:
- ReadWriteOnce
claimRef:
apiVersion: v1
kind: PersistentVolumeClaim
name: data-test-1
namespace: default
persistentVolumeReclaimPolicy: Retain
volumeMode: Filesystem
storageClassName: local
csi:
driver: com.localcsi
fsType: ext4
volumeHandle: caasvg_lv // volumeId
nodeAffinity:
required:
nodeSelectorTerms:
- matchExpressions:
- key: kubernetes.io/hostname
operator: In
values:
- master2
For the preceding two PVs, if I want to delete the first PV, only one
volumeId is sent to me when I invoke the volume deletion interface. but the
volumeId of the two PVs is the same and the volume of the node to be
deleted cannot be identified.
So raised this issue to add a parameter pvName in DeleteVolumeRequest.
Describe the solution you'd like in detail
image.png (view on web)
<https://github.com/container-storage-interface/spec/assets/11647782/93b4d585-4c66-46e8-9c4d-d1a45d757518>
—
Reply to this email directly, view it on GitHub
<#558>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR5KLCBKLMCYSEAGT7TZDTYH4XTVAVCNFSM6AAAAABAHZ5RVKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDMMZYGM2DIMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?/Why is this needed
Currently, the DeleteVolumeRequest is only one parameter VolumeId, which is used to transfer the volume to be deleted. However, this requirement cannot be met in the scenario where PV volumes are preset.
for example:
apiVersion: v1
kind: PersistentVolume
metadata:
annotations:
pv.kubernetes.io/provisioned-by: com.localcsi
pv.kubernetes.io/create-by: manual // Identifier Manually Preset
name: pv-test-0
spec:
capacity:
storage: 256Mi
accessModes:
claimRef:
apiVersion: v1
kind: PersistentVolumeClaim
name: data-test-0
namespace: default
persistentVolumeReclaimPolicy: Retain
volumeMode: Filesystem
storageClassName: local
csi:
driver: com.localcsi
fsType: ext4
volumeHandle: caasvg_lv // volumeId
nodeAffinity:
required:
nodeSelectorTerms:
operator: In
values:
apiVersion: v1
kind: PersistentVolume
metadata:
annotations:
pv.kubernetes.io/provisioned-by: com.localcsi
pv.kubernetes.io/create-by: manual // Identifier Manually Preset
name: pv-test-1
spec:
capacity:
storage: 256Mi
accessModes:
claimRef:
apiVersion: v1
kind: PersistentVolumeClaim
name: data-test-1
namespace: default
persistentVolumeReclaimPolicy: Retain
volumeMode: Filesystem
storageClassName: local
csi:
driver: com.localcsi
fsType: ext4
volumeHandle: caasvg_lv // volumeId
nodeAffinity:
required:
nodeSelectorTerms:
operator: In
values:
For the preceding two PVs, if I want to delete the first PV, only one volumeId is sent to me when I invoke the volume deletion interface. but the volumeId of the two PVs is the same and the volume of the node to be deleted cannot be identified.
So raised this issue to add a parameter pvName in DeleteVolumeRequest.
Describe the solution you'd like in detail
The text was updated successfully, but these errors were encountered: