Revert "use go v1.18 and update dependencies" #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc @liggitt |
|
The go1.18 change was fine, the genproto bump was the issue |
|
Also, note that |
This reverts commit 150c9d9 partially. It keep the go.mod module version to 1.18 but leave old versions of genproto.
humblec
force-pushed
the
revert-go-version
branch
from
2535230 to
3a1054e
Compare
|
@saad-ali it seems this would be worth cherry-picking for 1.7 |
|
LGTM Will merge and cherry pick to 1.7 |
|
Is there a related bug or issue where this was discussed? Curious who/where the related issues were caught? |
@saad-ali The references I have here is the one in PR description (150c9d9#r87967287) from @liggitt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Info#
This reverts commit 150c9d9 partially.
It keep the go.mod module version to 1.18 but leave old versions of genproto.
Dropping this dependency back to its prior level would help downstreams avoid pulling in a ton of extra deps till we figure out how to consume bits from genproto in a more isolated way
Ref# 150c9d9#r87967287
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce an API-breaking change?: