Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update protoc and related #552

Merged
merged 4 commits into from
Mar 5, 2024
Merged

update protoc and related #552

merged 4 commits into from
Mar 5, 2024

Commits on Feb 29, 2024

  1. update protoc and related 

    updated protoc to v25.2
updated protoc-gen-go to v1.32.0
added protoc-gen-go-grpc at v1.3.0

Modified the makefile to use "go install" to install tools.
Use extended regular expressions in "sed" command.

Fixes build on arm OSX host
    @huww98
    huww98 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    dd3276a View commit details
    Browse the repository at this point in the history

  2. fix github actions 

    Always run "make build_go" on github actions

Always update the timesptamp of spec.md/csi.proto to make sure lib/go is built on CI
    @huww98
    huww98 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    24095bc View commit details
    Browse the repository at this point in the history

  3. remove github.com/golang/protobuf usage

    @huww98
    huww98 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    8f1e1ac View commit details
    Browse the repository at this point in the history

  4. simplify Makefile 

    - use git to check for out-of-date generated files, avoids all the temp files and manual diff in the Makefile.
- not specify version for protoc-gen-go, it will use the version from go.mod
- do not copy over the protoc binary. Call it directly from unzipped path. So it can find the includes automatically, and we don't need the -I or --go_opts=Mxxx flags.
- use paths=source_relative to generate go files directly into destination, avoid the copy.
- simplify the sed command used to extract "csi.proto" file.
    @huww98
    huww98 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    266ee1a View commit details
    Browse the repository at this point in the history