Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'tenant' config to make snapshotter manage tcmu devices easier #279

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

BigVan
Copy link
Member

@BigVan BigVan commented Apr 16, 2024

There will be some tcmu device id conflicts if more than one snap- shotter process running on a single host. Add 'tenant' config to distinguish their own tcmu ID

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

There will be some tcmu device id conflicts if more than one snap-
shotter process running on a single host. Add 'tenant' config to
distinguish their own tcmu ID

Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
@liulanzheng liulanzheng added the ok-to-test Pull request is ok to run ci test label Apr 16, 2024
Copy link
Contributor

@yuchen0cc yuchen0cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuchen0cc yuchen0cc merged commit 69b3995 into containerd:main Apr 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Pull request is ok to run ci test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants