Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dereferencing null pointer value.HcaHandles #216

Closed
wants to merge 3 commits into from
Closed

Dereferencing null pointer value.HcaHandles #216

wants to merge 3 commits into from

Conversation

xuegege5290
Copy link

the problem about Dereferencing null pointer value.HcaHandles

Zyqsempai
Zyqsempai reviewed Dec 8, 2021
View reviewed changes
Copy link
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits still not signed + they should be squashed

@Zyqsempai
Copy link
Contributor

@xuegege5290 Squash (git squash or rebase -i) your commits and then sign it git commit --amend --signoff

@xuegege5290 xuegege5290 requested a review from Zyqsempai December 8, 2021 14:36
Zyqsempai
Zyqsempai reviewed Dec 8, 2021
View reviewed changes
Copy link
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, take a look at the comments above.

@Zyqsempai
Copy link
Contributor

I recommend following Git docs or tutorials, it's git related only.
Some random articles which could potentially help you.
https://www.internalpointers.com/post/squash-commits-into-one-git
https://stackoverflow.com/questions/13043357/git-sign-off-previous-commits

@kzys
Copy link
Member

kzys commented Feb 28, 2022

Seems superseded by #218.

@kzys kzys closed this Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zyqsempai Zyqsempai Zyqsempai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuegege5290 @Zyqsempai @kzys