[release/1.6] Fix compile from version control system (source) use case #10011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @austinvazquez. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
austinvazquez
changed the title
This change excludes the github.com/mitchellh/osext indirect dependency to resolve compile from source use case issue due to dependency no longer being available. Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
fix-offline-compilation
branch
from
0488845 to
7592f87
Compare
estesp
approved these changes
Mar 28, 2024
|
xref: #10012 (comment) |
|
/cc @thaJeztah @cpuguy83 |
henry118
approved these changes
Apr 1, 2024
corhere
added a commit
to corhere/containerd
that referenced
this pull request
Apr 5, 2024
containerd 1.6.31 Welcome to the v1.6.31 release of containerd! The thirty-first patch release for containerd 1.6 contains a few fixes, one for a regression that was introduced in v1.6.30 in the way process exits were handled. * Adds mediatype to OCI index record on export ([containerd#9991](containerd#9991)) * Fix runc shim to only defer init process exits ([containerd#10038](containerd#10038)) Please try out the release binaries and report any issues at https://github.com/containerd/containerd/issues. * Derek McGowan * Phil Estes * Akihiro Suda * Austin Vazquez * Laura Brehm * Maksym Pavlenko * Sebastiaan van Stijn * Talon <details><summary>14 commits</summary> <p> * Prepare for v1.6.31 release ([containerd#10040](containerd#10040)) * [`7f7012bad`](containerd@7f7012b) Prepare for v1.6.31 release * Fix runc shim to only defer init process exits ([containerd#10038](containerd#10038)) * [`5e53da4a1`](containerd@5e53da4) runc-shim: only defer init process exits * Fix compile from version control system (source) use case ([containerd#10011](containerd#10011)) * [`7592f87f0`](containerd@7592f87) Fix compile from version control system (source) use case * Adds mediatype to OCI index record on export ([containerd#9991](containerd#9991)) * [`8d415fd0e`](containerd@8d415fd) adds mediatype to oci index record * vendor: google.golang.org/protobuf 1.33.0, github.com/golang/protobuf v1.5.4 ([containerd#9974](containerd#9974)) * [`2dbb59b5a`](containerd@2dbb59b) vendor: github.com/golang/protobuf v1.5.4 * [`069bb78c9`](containerd@069bb78) build(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0 * [`68d395cad`](containerd@68d395c) build(deps): bump google.golang.org/protobuf from 1.31.0 to 1.32.0 * Backport test release on PR ([containerd#9955](containerd#9955)) * [`b3713136d`](containerd@b371313) CI: test release.yml on every PR </p> </details> * **github.com/golang/protobuf** v1.5.3 -> v1.5.4 * **google.golang.org/protobuf** v1.31.0 -> v1.33.0 Previous release can be found at [v1.6.30](https://github.com/containerd/containerd/releases/tag/v1.6.30)
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/common
that referenced
this pull request
Sep 17, 2024
Exclude the old, outdated, and problematic github.com/mitchellh/osext which was being dragged in by containerd. This is what containerd did in containerd/containerd#10011 and included it in 1.6.31. I tried bumping first to 1.6.31, but that dragged in a lot of stuff. I think this is safer, if it works. Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9969
The module github.com/mitchellh/osext is no longer available via source. The issue is it is currently a indirect dependency via containerd/aufs@v1.0.0 (see containerd/aufs#49 (comment)) and Microsoft/hcsshim@v0.9.10.
Description
This change excludes the github.com/mitchellh/osext indirect dependency to resolve compile from source use case issue due to dependency no longer being available.
Testing
Additional context