Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state/root bug in shim sandbox controller #11321

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

djdongjin
Copy link
Member

@djdongjin djdongjin commented Jan 28, 2025

Fix #11320

This is a shim-sandbox-controller side bug other than LoadExistingShims, as that function is also used in TaskManager and it passes the dirs correctly:

root, state := ic.Properties[plugins.PropertyRootDir], ic.Properties[plugins.PropertyStateDir]

return NewTaskManager(ic.Context, root, state, shimManager)

func NewTaskManager(ctx context.Context, root, state string, shims *ShimManager) (*TaskManager, error) {
if err := shims.LoadExistingShims(ctx, state, root); err != nil {

Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
Copy link
Member Author

fyi @mxpv @abel-von PTAL when you have some time. thank you!

@mxpv mxpv added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@mxpv mxpv added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@mxpv mxpv added this pull request to the merge queue Feb 4, 2025
Merged via the queue into containerd:main with commit 06329b2 Feb 4, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

SandboxController function call question
4 participants