-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove direct dependency on github.com/pkg/errors #71
Conversation
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
=======================================
Coverage 42.23% 42.23%
=======================================
Files 9 9
Lines 367 367
=======================================
Hits 155 155
Misses 181 181
Partials 31 31
Continue to review full report at Codecov.
|
I suggest releasing v1.1.0 after merging this |
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
b9627a0
to
b6c559f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
given the commit doesn't have a comment, was there a specific reason to not rely on pkg/errors?
Simply because “%w” is the standard way in Go since Go 1.13. |
No description provided.