Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove direct dependency on github.com/pkg/errors #71

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

AkihiroSuda
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2021

Codecov Report

Merging #71 (a29cf96) into main (548a5e1) will not change coverage.
The diff coverage is 0.00%.

❗ Current head a29cf96 differs from pull request most recent head b9627a0. Consider uploading reports for the commit b9627a0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   42.23%   42.23%           
=======================================
  Files           9        9           
  Lines         367      367           
=======================================
  Hits          155      155           
  Misses        181      181           
  Partials       31       31           
Impacted Files Coverage Δ
cni.go 70.96% <0.00%> (ø)
errors.go 0.00% <ø> (ø)
opts.go 15.90% <0.00%> (ø)
result.go 79.31% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548a5e1...b9627a0. Read the comment docs.

@AkihiroSuda
Copy link
Member Author

I suggest releasing v1.1.0 after merging this

cni.go Outdated Show resolved Hide resolved
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

given the commit doesn't have a comment, was there a specific reason to not rely on pkg/errors?

@AkihiroSuda
Copy link
Member Author

given the commit doesn't have a comment, was there a specific reason to not rely on pkg/errors?

Simply because “%w” is the standard way in Go since Go 1.13.

@dmcgowan dmcgowan merged commit 1697e73 into containerd:main Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants