Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to io/ioutil #89

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

austinvazquez
Copy link
Member

io/ioutil package has been marked deprecated in Go 1.16

Signed-off-by: Austin Vazquez macedonv@amazon.com

@codecov-commenter
Copy link

Codecov Report

Base: 20.95% // Head: 20.95% // No change to project coverage 👍

Coverage data is based on head (1ece5ab) compared to base (f5eef54).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   20.95%   20.95%           
=======================================
  Files           7        7           
  Lines         711      711           
=======================================
  Hits          149      149           
  Misses        524      524           
  Partials       38       38           
Impacted Files Coverage Δ
utils.go 20.00% <0.00%> (ø)
console.go 24.05% <100.00%> (ø)
runc.go 21.48% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@estesp
Copy link
Member

estesp commented Oct 27, 2022

Rebasing on main might correct this

io/ioutil package has been marked deprecated in Go 1.16

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@austinvazquez austinvazquez marked this pull request as ready for review October 27, 2022 17:26
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit 814a58e into containerd:main Nov 9, 2022
@austinvazquez austinvazquez deleted the remove-ioutil branch November 9, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants