Support syslog driver for nerdctl
#1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zheaoli
reviewed
Sep 12, 2022
AkihiroSuda
reviewed
Sep 12, 2022
|
I think this is ready for review. PTAL @Zheaoli @AkihiroSuda |
yuchanns
requested review from
Zheaoli and
AkihiroSuda
and removed request for
Zheaoli and
AkihiroSuda
|
AkihiroSuda
requested changes
Sep 19, 2022
|
SGTM |
yuchanns
requested review from
AkihiroSuda
and removed request for
Zheaoli and
fahedouch
|
It's ready. PTAL @AkihiroSuda |
AkihiroSuda
reviewed
Sep 23, 2022
AkihiroSuda
reviewed
Sep 23, 2022
AkihiroSuda
reviewed
Sep 23, 2022
AkihiroSuda
reviewed
Sep 23, 2022
AkihiroSuda
reviewed
Sep 23, 2022
AkihiroSuda
reviewed
Sep 23, 2022
fahedouch
reviewed
Sep 23, 2022
AkihiroSuda
reviewed
Sep 24, 2022
AkihiroSuda
reviewed
Sep 26, 2022
Signed-off-by: Hanchin Hsieh <me@yuchanns.xyz>
AkihiroSuda
added a commit
to AkihiroSuda/nerdctl
that referenced
this pull request
Jun 6, 2024
Hanchin Hsieh (yuchanns) served as a Reviewer of nerdctl from November 2022 to June 2024. Hanchin has made significant contributions such as the addition of syslog driver (containerd#1377) and IPv6 networking (containerd#1558). We show our huge appreciation to Hanchin. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1353
Related #1039
Since the std lib
log/sysloghas very limited functions and has been frozen, we should implement it by ourselves. There are trivial tasks to be done.Support dialtcp+tlsconnections. FYI RackSec/srslogSupport cross-compile on the Windows platform. FYI hashicorp/go-syslogSigned-off-by: Hanchin Hsieh me@yuchanns.xyz