Add zstd compress level support #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djdongjin
force-pushed
the
zstd-compress-level
branch
from
c455739
to
8dbfdf3
Compare
djdongjin
force-pushed
the
zstd-compress-level
branch
from
8dbfdf3
to
4e51c39
Compare
AkihiroSuda
reviewed
Nov 14, 2022
| @@ -66,6 +67,10 @@ func newImageConvertCommand() *cobra.Command { | |||
| imageConvertCommand.Flags().Int("estargz-compression-level", gzip.BestCompression, "eStargz compression level") | |||
| imageConvertCommand.Flags().Int("estargz-chunk-size", 0, "eStargz chunk size") | |||
| imageConvertCommand.Flags().Bool("zstdchunked", false, "Use zstd compression instead of gzip (a.k.a zstd:chunked). Should be used in conjunction with '--oci'") | |||
| imageConvertCommand.Flags().String("zstdchunked-record-in", "", "Read 'ctr-remote optimize --record-out=<FILE>' record file (EXPERIMENTAL)") | |||
There was a problem hiding this comment.
Record-in should be experimental https://github.com/containerd/nerdctl/blob/main/docs/experimental.md
|
The commit message doesn’t seem to reflect the actual content of the commit |
Signed-off-by: Jin Dong <jindon@amazon.com>
djdongjin
force-pushed
the
zstd-compress-level
branch
from
4e51c39
to
b0434b5
Compare
|
@AkihiroSuda Thanks for review. Updated the doc to mention zstdchunked-record-in as experimental and the commit message. |
ktock
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1367
This PR in
stargzadds support for customizing zstd compression level inctr-remote. This PR does a similar thing to add the support in nerdctl.I tested the change locally using the
stargzmain branch. After the new version ofstargzis released (with the change in that PR), it should work.Signed-off-by: Jin Dong jindon@amazon.com