Use docker compose v2 by default in test-integration-docker-compatibility
#1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djdongjin
force-pushed
the
test-compose-v2
branch
3 times, most recently
from
a1c514e
to
2088215
Compare
|
@djdongjin Do you still plan to work on this? |
djdongjin
force-pushed
the
test-compose-v2
branch
16 times, most recently
from
2783754
to
a451630
Compare
djdongjin
force-pushed
the
test-compose-v2
branch
from
a451630
to
681f90b
Compare
djdongjin
changed the title
test-integration-docker-compatibilitytest-integration-docker-compatibility
@AkihiroSuda the PR is ready for review, thanks |
AkihiroSuda
reviewed
Jun 7, 2023
AkihiroSuda
reviewed
Jun 7, 2023
AkihiroSuda
reviewed
Jun 7, 2023
djdongjin
force-pushed
the
test-compose-v2
branch
2 times, most recently
from
2f528f4
to
f3c923e
Compare
Signed-off-by: Jin Dong <djdongjin95@gmail.com> Resolve comments Signed-off-by: Jin Dong <djdongjin95@gmail.com>
djdongjin
force-pushed
the
test-compose-v2
branch
from
f3c923e
to
de5bc94
Compare
AkihiroSuda
reviewed
Jun 8, 2023
| @@ -51,6 +51,7 @@ services: | |||
| t.Logf("projectName=%q", projectName) | |||
| defer base.ComposeCmd("-f", comp.YAMLFullPath(), "down", "-v").Run() | |||
|
|
|||
| defer base.Cmd("rm", "-f", "-v", containerName).Run() | |||
There was a problem hiding this comment.
Isn't defer base.ComposeCmd("-f", comp.YAMLFullPath(), "down", "-v").Run() (L52) enough?
There was a problem hiding this comment.
It didn't work in docker (compose), e.g., containers from docker compose run (i.e., not from docker compose up) won't be covered by docker compose down:
$ cat docker-compose.yaml
version: '3.1'
services:
svc0:
image: nginx
svc1:
image: rabbitmq
# docker compose down cannot down container from docker compose run
$ docker compose run -d svc0
[+] Running 1/0
✔ Network tmp_default Created 0.0s
103f148596f2d629f2b875d83da6ac5ea3682ad85b8c61d58e73ddc7931f3b11
$ docker compose down -v
[+] Running 1/0
✘ Network tmp_default Error 0.0s
failed to remove network tmp_default: Error response from daemon: error while removing network: network tmp_default id 3795360bd3e1e9a11def2a76f140597f328009fb101bd7d67490bdeebb8b54f9 has active endpoints
$ docker ps
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
103f148596f2 nginx "/docker-entrypoint.…" 24 seconds ago Up 23 seconds 80/tcp tmp-svc0-run-db8a05f1f3e6
# works fine if from docker compose up
$ docker compose up -d
[+] Running 2/2
✔ Container tmp-svc1-1 Started 0.2s
✔ Container tmp-svc0-1 Started 0.3s
$ docker compose down -v
[+] Running 3/2
✔ Container tmp-svc0-1 Removed 0.1s
✔ Container tmp-svc1-1 Removed 6.3s
✔ Network tmp_default Removed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1577
Signed-off-by: Jin Dong djdongjin95@gmail.com