-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compose create #1668
Add compose create #1668
Conversation
fe5c91d
to
326a9e0
Compare
326a9e0
to
19f197f
Compare
pkg/composer/create.go
Outdated
"golang.org/x/sync/errgroup" | ||
) | ||
|
||
// FYI: https://github.com/docker/compose/blob/v2/pkg/api/api.go#L423 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// FYI: https://github.com/docker/compose/blob/v2/pkg/api/api.go#L423 | |
// FYI: https://github.com/docker/compose/blob/v2.14.1/pkg/api/api.go#L423 |
for permanence.
Same applies to other comment lines too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Signed-off-by: Jin Dong <jindon@amazon.com>
Signed-off-by: Jin Dong <jindon@amazon.com>
19f197f
to
38d03da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This PR adds
compose create
command and its flags: https://docs.docker.com/engine/reference/commandline/compose_create/There are some follow-up TODOs/refactors which I think we can track in issues/follow-up PRs because they're not trivial and involves several dependent commands and pkgs. Including them in the same PR might make it too large/confusing.
cmd
instead ofpkg
(also due to other dependency being incmd
), making it hard to reuse.compose up
implementation should be visited/decoupled:up
should equal tocreate
+start
(logic are resuable,up
can utilizecreated
containers)up
increate
(run
as well)up|create|start
(possiblycompose run
as well)This should be the last compose command 😄 (before some refactor happens). After this, there are two remaining commands: