setPlatformOptions: Change signature #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes `setPlatformOptions`' signature to avoid passing back a fresh copy of an internalLabels structure when we could just pass in a pointer and have the function set whats needed. This additionally removes the opts parameter as the naming is a bit odd for this. To me, reading the function name it'd seem as if we're going to make use of the opts in the body (e.g. actually apply/set them) but we just append to the slice internally. I've changed to returning a new slice that makes it more obvious that all we're doing internally is tallying up each platforms specific options and returning them. Signed-off-by: Danny Canter <danny@dcantah.dev>
Merged
AkihiroSuda
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
setPlatformOptions' signature to avoid passing back a fresh copy of an internalLabels structure when we could just pass in a pointer and have the function set whats needed. This additionally removes the opts parameter as the naming is a bit odd for this. To me, reading the function name it'd seem as if we're going to make use of the opts in the body (e.g. actually apply/set them) but we just append to the slice internally. I've changed to returning a new slice that makes it more obvious that all we're doing internally is tallying up each platforms specific options and returning them.