ipfs: move to net/http-based implementation instead of binary-based one
#1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jan 24, 2023
go.mod
Outdated
| @@ -16,7 +16,7 @@ require ( | |||
| github.com/containerd/nydus-snapshotter v0.5.0 | |||
| github.com/containerd/stargz-snapshotter v0.13.0 | |||
| github.com/containerd/stargz-snapshotter/estargz v0.13.0 | |||
| github.com/containerd/stargz-snapshotter/ipfs v0.13.1-0.20230106161838-6844dbb4c428 | |||
| github.com/containerd/stargz-snapshotter/ipfs v0.13.1-0.20230123103003-7aade82f8b66 | |||
ktock
force-pushed
the
ipfsclient
branch
2 times, most recently
from
6bf2d91
to
cb79149
Compare
AkihiroSuda
reviewed
Jan 25, 2023
go.mod
Outdated
| github.com/containerd/stargz-snapshotter/ipfs v0.13.1-0.20230106161838-6844dbb4c428 | ||
| github.com/containerd/stargz-snapshotter v0.14.0 | ||
| github.com/containerd/stargz-snapshotter/estargz v0.14.0 | ||
| github.com/containerd/stargz-snapshotter/ipfs v0.14.0 |
There was a problem hiding this comment.
The snapshotter daemon binary has to be updated too
|
Still draft? |
Yes. Fixing the bug through containerd/stargz-snapshotter#1082 . |
ktock
force-pushed
the
ipfsclient
branch
2 times, most recently
from
404502c
to
42a06ce
Compare
… one Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
AkihiroSuda
reviewed
Jan 27, 2023
| } | ||
| } | ||
| imageIDs = base.Cmd("images", "--no-trunc", "-a", "-q").OutLines() | ||
| base.Cmd(append([]string{"rmi", "-f"}, imageIDs...)...).AssertOK() | ||
| } |
There was a problem hiding this comment.
It looks like that the recent nerdctl rmi strictlly requires each container's image exists in the image service and it has a logic to avoid removing images of existing containers.
This part of code didn't seem to meet this requirement and it seems to result in CI failures that report a container's corresponding image doesn't exist in the image store.
So this part tries to fix it by using nerdctl rmi.
AkihiroSuda
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By this commit, nerdctl works without relying on executing the ipfs binary (ipfs daemon still needs to be running).