Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update system prune flag --all confirmation prompt #2044

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

suyanhanx
Copy link
Contributor

As both image.Prune and builder.Prune now support only removing dangling items or not, the confirmation prompt for the flag --all of system prune need to update.


I'm sorry that some code changes were reverted due to my mistake in operating the git rebase.

if !options.All {
logrus.Warn("Currently, `nerdctl system prune` requires --all to be specified. Skip pruning.")
// NOP
return false, nil
}

This PR removed them.

Signed-off-by: Han Xu suyanhanx@gmail.com

Signed-off-by: Han Xu <suyanhanx@gmail.com>
@AkihiroSuda AkihiroSuda added this to the v1.2.1 milestone Feb 24, 2023
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit e09d7f8 into containerd:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants