Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS: add Kay Yan (yankay) as a REVIEWER #2482

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Sep 8, 2023

Kay Yan (@yankay) has been very actively contributing to the project:
https://github.com/containerd/nerdctl/pulls?q=author%3Ayankay+

So I'd like to invite @yankay as a reviewer

Needs explicit LGTM from @yankay and 1/3 of the nerdctl Committers ( $ceil \left( 4 \times \frac{1}{3} \right) = 2$ ), according to
https://github.com/containerd/project/blob/main/GOVERNANCE.md :

After a candidate has been informally proposed in the maintainers forum, the
existing maintainers are given seven days to discuss the candidate, raise
objections and show their support. Formal voting takes place on a pull request
that adds the contributor to the MAINTAINERS file. Candidates must be approved
by 2/3 of the current committers by adding their approval or LGTM to the pull
request. The reviewer role has the same process but only requires 1/3 of current
committers.
If a candidate is approved, they will be invited to add their own LGTM or
approval to the pull request to acknowledge their agreement. A committer will
verify the numbers of votes that have been received and the allotted seven days
have passed, then merge the pull request and invite the contributor to the
organization.
For non-core sub-projects, only committers of the repository that the candidate
is proposed for are given votes.

I'd also like to get a few LGTMs from the Core Committers too. (not necessary)

This PR will remain open for 7 days.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Copy link
Member

@Zheaoli Zheaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,Welcome!

@yankay
Copy link
Contributor

yankay commented Sep 8, 2023

Thanks

It's my pleasure to contribute to the nerdctl .
And I want to try my best to work as a reviewer :-)

LGTM

Copy link
Member

@ktock ktock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Welcome :)

@AkihiroSuda AkihiroSuda requested a review from a team September 14, 2023 06:24
@AkihiroSuda AkihiroSuda added this to the v1.5.1 milestone Sep 15, 2023
@AkihiroSuda AkihiroSuda merged commit 017b0ea into containerd:main Sep 15, 2023
@AkihiroSuda
Copy link
Member Author

Sent a GitHub invitation to @yankay

@yankay
Copy link
Contributor

yankay commented Sep 16, 2023

Sent a GitHub invitation to @yankay

Thanks @AkihiroSuda, @Zheaoli , @ktock , @fahedouch

I'll try my best :-)

@AkihiroSuda
Copy link
Member Author

@yankay "yankay" on cloud-native.slack.com is your account?
(Sorry, forgot to invite you to the private maintainer channel.)

@yankay
Copy link
Contributor

yankay commented Jan 24, 2024

HI @AkihiroSuda
yankay on cloud-native.slack.com is my account. Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants