-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINTAINERS: add Kay Yan (yankay) as a REVIEWER #2482
Conversation
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,Welcome!
Thanks It's my pleasure to contribute to the nerdctl . LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Welcome :)
Sent a GitHub invitation to @yankay |
Thanks @AkihiroSuda, @Zheaoli , @ktock , @fahedouch I'll try my best :-) |
@yankay "yankay" on |
HI @AkihiroSuda |
Kay Yan (@yankay) has been very actively contributing to the project:
https://github.com/containerd/nerdctl/pulls?q=author%3Ayankay+
So I'd like to invite @yankay as a reviewer
Needs explicit LGTM from @yankay and 1/3 of the nerdctl Committers ($ceil \left( 4 \times \frac{1}{3} \right) = 2$ ), according to
https://github.com/containerd/project/blob/main/GOVERNANCE.md :
I'd also like to get a few LGTMs from the Core Committers too. (not necessary)
This PR will remain open for 7 days.