Support run container with network id #2589
Merged
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahedouch
force-pushed
the
support-run-with-network-id
branch
2 times, most recently
from
4218424
to
58391b8
Compare
fahedouch
changed the title
fahedouch
force-pushed
the
support-run-with-network-id
branch
from
719376d
to
4d14983
Compare
AkihiroSuda
reviewed
Oct 24, 2023
| { | ||
| args: []string{"--net", "host"}, | ||
| }, | ||
| } | ||
| for _, tc := range testCases { | ||
| tc := tc // IMPORTANT | ||
| if tc.dockerIncompatible { | ||
| // docker compute id algorithm is different from nerdctl | ||
| testutil.DockerIncompatible(t) |
There was a problem hiding this comment.
This should be compatible if you inspect the id via docker network inspect
fahedouch
force-pushed
the
support-run-with-network-id
branch
from
36e1772
to
fbea131
Compare
|
Please rebase to make CI green |
Closed
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
fahedouch
force-pushed
the
support-run-with-network-id
branch
from
fbea131
to
792a0cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2436