chore(test): remove some incompatible in compose test #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyanhanx
force-pushed
the
remove-incompatible-in-compose-test
branch
from
297ed1d
to
d42b00b
Compare
yuchanns
reviewed
Nov 2, 2023
suyanhanx
force-pushed
the
remove-incompatible-in-compose-test
branch
2 times, most recently
from
cc0bc32
to
211848b
Compare
AkihiroSuda
reviewed
Nov 2, 2023
| @@ -60,8 +57,12 @@ services: | |||
| base.ComposeCmd("-p", projectName, "-f", compFull.YAMLFullPath(), "up", "-d").AssertOK() | |||
| defer base.ComposeCmd("-p", projectName, "-f", compFull.YAMLFullPath(), "down", "--remove-orphans").AssertOK() | |||
|
|
|||
| base.ComposeCmd("-p", projectName, "-f", compOrphan.YAMLFullPath(), "down", "-v").AssertCombinedOutContains("is in use") | |||
|
|
|||
| // The error output is different with docker | |||
There was a problem hiding this comment.
Or just check "in use"
It looks okay. But it may not be clear enough as to the meaning of whether or not.
AkihiroSuda
reviewed
Nov 2, 2023
| base.ComposeCmdWithHelper(unbuffer, "-f", comp.YAMLFullPath(), "exec", "-t=false", "svc0", "stty").AssertFail() // `-i` | ||
| base.ComposeCmdWithHelper(unbuffer, "-f", comp.YAMLFullPath(), "exec", "-i=false", "-t=false", "svc0", "stty").AssertFail() | ||
|
|
||
| // The error output is different with docker |
There was a problem hiding this comment.
No. They even don't have the same exit code. We might have to deal with this one separately.
There was a problem hiding this comment.
Why can't we make the exit code same?
There was a problem hiding this comment.
If it is difficult for now it should be just marked as DockerIncompatible and we can revisit it later
There was a problem hiding this comment.
This change has been reverted.
suyanhanx
force-pushed
the
remove-incompatible-in-compose-test
branch
from
211848b
to
ccace18
Compare
Signed-off-by: Han Xu <suyanhanx@gmail.com>
suyanhanx
force-pushed
the
remove-incompatible-in-compose-test
branch
from
ccace18
to
d9d684b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2622