Add builder prune --all and --force flag support #3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
add-builder-prune-all
branch
from
0f162db
to
320420c
Compare
pendo324
approved these changes
Aug 15, 2024
cmd/nerdctl/builder.go
Outdated
| msg string | ||
| ) | ||
|
|
||
| if !options.All { |
There was a problem hiding this comment.
nit: might be slightly easier to read if you reverse this conditional, since we need to handle both cases anyway
This change adds support for builder prune --all and --force. A refactor of previous tests which used builder prune functionality was required to handle the new confirmation prompt. A test utility was added to handle this for reuse by current and future tests. Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
add-builder-prune-all
branch
from
320420c
to
f5d1d6d
Compare
AkihiroSuda
reviewed
Aug 16, 2024
| @@ -82,4 +82,6 @@ type BuilderPruneOptions struct { | |||
| BuildKitHost string | |||
| // All will remove all unused images and all build cache, not just dangling ones | |||
| All bool | |||
| // Force will not prompt for confirmation. | |||
| Force bool | |||
There was a problem hiding this comment.
Looks like it ended up being used on the CLI side only, so not much reason to pass it to the package backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for builder prune
--alland--force. A refactorof previous tests which used builder prune functionality was required to
handle the new confirmation prompt. A test utility was added to handle
this for reuse by current and future tests.
Testing
From
containerd/nerdctl:Next steps
builder duimplementation