Add image prune --filter support #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
feat-add-image-prune-filter
branch
from
8164d4e
to
7d9b1cc
Compare
austinvazquez
force-pushed
the
feat-add-image-prune-filter
branch
2 times, most recently
from
d1935e7
to
360423f
Compare
AkihiroSuda
reviewed
Aug 17, 2024
cmd/nerdctl/image_prune_test.go
Outdated
| base.Cmd("images", "--all").AssertOutContains(imageName) | ||
|
|
||
| // Pause to ensure enough time has passed for the image to be clean on next prune. | ||
| time.Sleep(1 * time.Second) |
There was a problem hiding this comment.
Tried increase the pause to 3 seconds and lowering the requirement to 10ms to provide two orders of magnitude here. Should be pretty reliable. 😅
AkihiroSuda
reviewed
Aug 17, 2024
pkg/imgutil/filtering_test.go
Outdated
| }, | ||
| { | ||
| name: "SingleMatchingLabel", | ||
| imageLabels: map[string]string{"org": "com.containerd.nerdctl"}, |
There was a problem hiding this comment.
Better to use com.example...
austinvazquez
force-pushed
the
feat-add-image-prune-filter
branch
from
360423f
to
08d2a8c
Compare
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
feat-add-image-prune-filter
branch
from
08d2a8c
to
7c9751e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds nerdctl image prune
--filtersupport including:image prune --filter label=<key>=<value>image prune --filter until=<timestamp>Testing
pkg/imgutilcodecmd/nerdctl/image_prunecodeTestImagePruneFilterUntildoes not currently work on Docker. Docker image's created timestamp is aligning with the timestamp of the base image. Docker supports theuntilfilter; just didn't have any ideas for deterministically testing both behaviors.References