New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'none' logger #3633

Merged

AkihiroSuda merged 1 commit into containerd:main from coderbirju:add-none-logger

Nov 5, 2024

Contributor

coderbirju commented Nov 1, 2024 •

edited

Loading

Attempt at adding option "none" for nerdctl run with --log-driver flag.
#1039

Feedback welcome.

Testing Done:

sudo ./_output/nerdctl run \
  --log-driver=none \
  --name my-container \
  nginx

Verified that <conatinerd-id>-json.log file is not created in
/var/lib/nerdctl/1935db59/containers/default/<container-id> folder

Verified that sudo nerdctl logs my-container exits with
log type `none` was selected, nothing to log

Ignoring hostname lifecycle.json log-config.json oci-hook.createRuntime.log resolv.conf files within
/var/lib/nerdctl/1935db59/containers/default/<container-id> folder
I believe these are not container logs and as such are not in scope of being removed with the --log-driver flag

coderbirju force-pushed the add-none-logger branch 2 times, most recently from b62d4b6 to b872a0d Compare

November 1, 2024 20:44

coderbirju marked this pull request as ready for review

November 1, 2024 21:07

AkihiroSuda added the area/logging label

AkihiroSuda reviewed

View reviewed changes

cmd/nerdctl/main.go Outdated Show resolved Hide resolved

AkihiroSuda reviewed

View reviewed changes

pkg/logging/none_logger_test.go Outdated Show resolved Hide resolved

AkihiroSuda reviewed

View reviewed changes

pkg/logging/none_logger_test.go Outdated Show resolved Hide resolved

djdongjin reviewed

View reviewed changes

pkg/logging/log_viewer.go Outdated Show resolved Hide resolved

pkg/logging/none_logger_test.go Outdated Show resolved Hide resolved

coderbirju force-pushed the add-none-logger branch from b872a0d to 2143013 Compare

November 4, 2024 03:57

AkihiroSuda reviewed

View reviewed changes

pkg/logging/none_logger_test.go Outdated Show resolved Hide resolved

AkihiroSuda reviewed

View reviewed changes

pkg/logging/none_logger_test.go Outdated Show resolved Hide resolved

coderbirju force-pushed the add-none-logger branch from 2143013 to 619b8e9 Compare

November 4, 2024 17:45


          add 'none' logger

c607537

Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>

coderbirju force-pushed the add-none-logger branch from 619b8e9 to c607537 Compare

November 4, 2024 18:51

AkihiroSuda added this to the v2.0.0 milestone

AkihiroSuda approved these changes

View reviewed changes

Member

AkihiroSuda left a comment

Thanks

AkihiroSuda merged commit 9bd0ab9 into containerd:main

30 checks passed

coderbirju mentioned this pull request

Finch does not support logging driver "none" runfinch/finch#670

Open

github-actions bot mentioned this pull request

Bump nerdctl from 1.7.6 to 2.0.0 kokyhm/kubespray#73

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels