nerdctl: add --env-file to exec
#413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Oct 5, 2021
| &cli.StringSliceFlag{ | ||
| Name: "env-file", | ||
| Usage: "Set environment variables from file", | ||
| }, |
There was a problem hiding this comment.
Could you update the document?
https://github.com/containerd/nerdctl#whale-nerdctl-exec
|
Thanks, LGTM except the document.
|
|
Updated docs. PTAL
|
AkihiroSuda
reviewed
Oct 5, 2021
README.md
Outdated
| @@ -480,6 +480,7 @@ Flags: | |||
| - :whale: `-d, --detach`: Detached mode: run command in the background | |||
| - :whale: `-w, --workdir`: Working directory inside the container | |||
| - :whale: `-e, --env`: Set environment variables | |||
| - :whale: `--env-file`: Set environment variables from file | |||
| - :whale: `--privileged`: Give extended privileges to the command | |||
|
|
|||
| Unimplemented `docker exec` flags: `--detach-keys`, `--env-file`, `--user` | |||
There was a problem hiding this comment.
env-file can be now removed from “Unimplemented” list
Reference: containerd#215 ```shell vbatts@melisma:~$ sudo nerdctl --version nerdctl version 0.12.0-6-g6ca74e6.m vbatts@melisma:~$ sudo nerdctl exec -it --env FOO=bar farts sh HOME=/root TERM=xterm PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin FOO=bar PWD=/ vbatts@melisma:~$ cat > env.sh FOO=VAT vbatts@melisma:~$ sudo nerdctl exec -it --env-file ./env.sh farts sh HOME=/root TERM=xterm PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin FOO=VAT PWD=/ vbatts@melisma:~$ cat > env.sh FOO=bar Bif=BAZ vbatts@melisma:~$ sudo nerdctl exec -it --env-file ./env.sh farts sh Bif=BAZ HOME=/root TERM=xterm PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin FOO=bar PWD=/ BAZ ``` Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
|
env-file can be now removed from “Unimplemented” list
ah yeah. Fixed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #215
Signed-off-by: Vincent Batts vbatts@hashbangbash.com