Unfork spf13/{cobra, pflag} #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @robberphex |
This comment has been minimized.
This comment has been minimized.
AkihiroSuda
force-pushed
the
unfork-cobra
branch
2 times, most recently
from
a62e461
to
f81e474
Compare
AkihiroSuda
force-pushed
the
unfork-cobra
branch
2 times, most recently
from
5a88651
to
21452aa
Compare
This comment has been minimized.
This comment has been minimized.
AkihiroSuda
force-pushed
the
unfork-cobra
branch
3 times, most recently
from
97e6437
to
a5baffd
Compare
|
It looks work to me, and thanks for fixing cli related issues. |
ktock
reviewed
Nov 18, 2021
AkihiroSuda
force-pushed
the
unfork-cobra
branch
2 times, most recently
from
215c661
to
e78f4b3
Compare
- Add `AddStringFlag()` to support aliases such as `--storage-driver` and env vars such as `$CONTAINERD_SNAPSHOTTER` - Set `mainHelpTemplate` to support command categories - Fix help string of `nerdctl run` - Mark `nerdctl -a` as non-persistent to avoid conflicting with `nerdctl images -a` - Mark `nerdctl -n` as non-persistent to avoid conflicting with `nerdctl logs -n` - Mark `nerdctl compose -f` as non-persistent to avoid conflicting with `nerdctl compose logs -f` - Set `rootCmd.RunE = unknownSubcommandAction` to make `nerdctl non-existent-command` fail Fix issue 522 Fix issue 510 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
unfork-cobra
branch
from
e78f4b3
to
c9d49e9
Compare
ktock
approved these changes
Nov 18, 2021
This was referenced Nov 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See the commit message)
Fix #522
Fix #510
I'll release v0.14.0 after merging this