Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup network for cgroupv2 stats #548

Merged

Conversation

fahedouch
Copy link
Member

fix #516
Signed-off-by: fahed dorgaa fahed.dorgaa@gmail.com

@fahedouch fahedouch changed the title fixes setup network for cgroupv2 stats Nov 21, 2021
@fahedouch fahedouch force-pushed the setup-network-for-cgroupv2-stats branch from 54a0124 to 2336eac Compare November 21, 2021 19:30
@AkihiroSuda AkihiroSuda added this to the v0.14.1, or maybe v0.15.0 milestone Nov 22, 2021
@fahedouch fahedouch force-pushed the setup-network-for-cgroupv2-stats branch 3 times, most recently from df8d39d to 7873a54 Compare November 23, 2021 15:08
@fahedouch fahedouch force-pushed the setup-network-for-cgroupv2-stats branch 2 times, most recently from 9ac8666 to d1d105b Compare November 23, 2021 16:10
@AkihiroSuda
Copy link
Member

fixes

Please set a descriptive commit message

go.mod Outdated
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
golang.org/x/sys v0.0.0-20211117180635-dee7805ff2e1
golang.org/x/term v0.0.0-20210927222741-03fcf44c2211
gotest.tools/v3 v3.0.3
)

// Temporary fork for avoiding importing patent-protected code: https://github.com/hashicorp/golang-lru/issues/73
// Temporary fork for avoiding importing patent-protected code: https://github.com/hashicorp/g20211117183948-ae814b36b871olang-lru/issues/73
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

????

Copy link
Member Author

@fahedouch fahedouch Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry! I don't know where it comes from ^^, fixed

@fahedouch fahedouch force-pushed the setup-network-for-cgroupv2-stats branch from 004255e to 24e4c2b Compare November 23, 2021 17:02
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
@fahedouch fahedouch force-pushed the setup-network-for-cgroupv2-stats branch from 24e4c2b to 48ed404 Compare November 23, 2021 17:02
@fahedouch
Copy link
Member Author

fahedouch commented Nov 23, 2021

fixes

Please set a descriptive commit message

sorry I lost messages when rebasing :) . Fixed

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit ad840ff into containerd:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stats: NETWORK I/O missing on cgroup v2 hosts
2 participants