Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/nerdctl: support (backport) zstdchunked convert #575

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

zchee
Copy link
Contributor

@zchee zchee commented Nov 28, 2021

Support (actually, backport of stargz-snapshotter/cmd/ctr-remote) zstdchunked convert.

@zchee
Copy link
Contributor Author

zchee commented Nov 28, 2021

Should I also update README.md - image-convert section?

@zchee zchee marked this pull request as ready for review November 28, 2021 17:10
@zchee
Copy link
Contributor Author

zchee commented Nov 28, 2021

Hmm, failed TestIPFSWithLazyPulling and TestIPFSWithLazyPullingCommit testcases...

@ktock
Copy link
Member

ktock commented Nov 29, 2021

Thanks for this PR! Changes look good to me.

Should I also update README.md - image-convert section?

Yes, please.

@AkihiroSuda AkihiroSuda added enhancement New feature or request impact/major labels Nov 29, 2021
@AkihiroSuda AkihiroSuda added this to the v0.15.0 milestone Nov 29, 2021
@zchee
Copy link
Contributor Author

zchee commented Nov 29, 2021

@ktock @AkihiroSuda PTAL

@AkihiroSuda
Copy link
Member

Please squash commits

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@zchee
Copy link
Contributor Author

zchee commented Nov 29, 2021

@AkihiroSuda PTAL again.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 1a7b29c into containerd:master Nov 29, 2021
@zchee zchee deleted the zstdchunked branch November 29, 2021 11:32
@zchee
Copy link
Contributor Author

zchee commented Nov 29, 2021

@AkihiroSuda @ktock You too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request impact/major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants