enhance login prompt #752
enhance login prompt #752
Conversation
fahedouch
force-pushed
the
prompt-username-login
branch
2 times, most recently
from
7890f57
to
d3d332c
Compare
|
Not entering the username raises the following error I had the same issue when assigning the username, By not entering username, the value will be a newline and option.username raises the above error. |
|
Please squash |
cmd/nerdctl/login_unix.go
Outdated
| if term.IsTerminal(syscall.Stdin) { | ||
| fd = os.Stdin | ||
| } else { | ||
| tty, err := os.Open("/dev/tty") |
There was a problem hiding this comment.
Shouldn’t we just read stdin even when it is not a terminal?
There was a problem hiding this comment.
I would like to know the use case that one would pass username and password by stdin and why, then password alone has such case, because of secret that is passed but username as stdin? docker login has only password stdin option.
cat secret-password | docker login --username foo --password-stdin
There was a problem hiding this comment.
adding username to stdin is not intuitive without username-stdin which is rarely used.
There was a problem hiding this comment.
So, readUsername() should return an error when stdin is not a terminal?
I don't think we have to open /dev/tty here.
There was a problem hiding this comment.
Added a follow-up commit to avoid /dev/tty
fahedouch
force-pushed
the
prompt-username-login
branch
from
804d2ce
to
ca2fec4
Compare
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
fahedouch
force-pushed
the
prompt-username-login
branch
from
ca2fec4
to
c933f8e
Compare
AkihiroSuda
force-pushed
the
prompt-username-login
branch
from
adb7d1f
to
5f6fe17
Compare
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
prompt-username-login
branch
from
5f6fe17
to
5a999f4
Compare
replace #641 ( thanks @simorgh1 )
Signed-off-by: fahed dorgaa fahed.dorgaa@gmail.com