Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS: add Ye Sijun (Junnplus) as a REVIEWER #784

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Feb 6, 2022

Ye Sijun (@junnplus) has made significant contributions such as fixing nerdctl login regressions (https://github.com/containerd/nerdctl/issues?q=author%3AJunnplus), so I'd like to invite @junnplus to be a Reviewer.

Needs explicit LGTM from @junnplus and 1/3 of the nerdctl Committers (ceil(2 * 1/3) = 1), according to https://github.com/containerd/project/blob/main/GOVERNANCE.md :

I'd also like to get a few LGTMs from the Core Committers too. (not necessary)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Copy link
Member

@ktock ktock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid
Copy link
Member

fuweid commented Feb 6, 2022

LGTM and 新年(初六)快乐🎆🍾️🎉🎊

@junnplus
Copy link
Member

junnplus commented Feb 6, 2022

Thanks and LGTM.

@fahedouch
Copy link
Member

LGTM and welcome to the family @junnplus

@dmcgowan dmcgowan merged commit 7427221 into containerd:master Feb 7, 2022
@AkihiroSuda
Copy link
Member Author

新年快乐 ㊗️
欢迎加入~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants