fixe image size #789
Merged
fixe image size #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahedouch
force-pushed
the
fix-image-size-output
branch
2 times, most recently
from
0829c5e
to
d057276
Compare
AkihiroSuda
requested changes
Feb 8, 2022
AkihiroSuda
reviewed
Feb 8, 2022
cmd/nerdctl/images.go
Outdated
| @@ -314,8 +314,8 @@ func (key snapshotKey) add(ctx context.Context, s snapshots.Snapshotter, usage * | |||
|
|
|||
| // unpackedImageSize is the size of the unpacked snapshots. | |||
| // Does not contain the size of the blobs in the content store. (Corresponds to Docker). | |||
There was a problem hiding this comment.
Maybe we should show both the blob size and the unpacked size to avoid confusion for multi-platform images
|
related issue #796 |
fahedouch
force-pushed
the
fix-image-size-output
branch
2 times, most recently
from
eb61341
to
5a3e74f
Compare
AkihiroSuda
reviewed
Feb 14, 2022
cmd/nerdctl/images.go
Outdated
| @@ -109,7 +109,8 @@ type imagePrintable struct { | |||
| ID string // image target digest (not config digest, unlike Docker), or its short form | |||
| Repository string | |||
| Tag string // "<none>" or tag | |||
| Size string | |||
| UnpackedSize string // the size of the unpacked snapshots. | |||
There was a problem hiding this comment.
the Size field needs to be retained for Docker compatibility
AkihiroSuda
reviewed
Feb 14, 2022
cmd/nerdctl/images.go
Outdated
| } else { | ||
| fmt.Fprintln(w, "REPOSITORY\tTAG\tIMAGE ID\tCREATED\tPLATFORM\tSIZE") | ||
| fmt.Fprintln(w, "REPOSITORY\tTAG\tIMAGE ID\tCREATED\tPLATFORM\tSIZE\tBLOB_SIZE") |
There was a problem hiding this comment.
Do we use underscore in other places?
There was a problem hiding this comment.
@AkihiroSuda I see spaces , BLOB SIZE WDYT ?
fahedouch
force-pushed
the
fix-image-size-output
branch
from
e93423e
to
3dcd2ac
Compare
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
fahedouch
force-pushed
the
fix-image-size-output
branch
from
3dcd2ac
to
9cd964d
Compare
|
We should do some benchmark and probably have |
|
@AkihiroSuda I think we can merge this, I will open a new PR for benchmark improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing #777
ImageSizeis the size of the unpacked snapshots. for multi-platform image, snapshot host single platform layer(s). So the computing of image size shouldn't be based on image platformSigned-off-by: fahed dorgaa fahed.dorgaa@gmail.com