refactor compose and support multi compose files #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junnplus
force-pushed
the
compose-multi-files
branch
6 times, most recently
from
173d7aa
to
faf0969
Compare
|
Looks like a nit ( spelling mistake ) in |
junnplus
force-pushed
the
compose-multi-files
branch
from
faf0969
to
af31080
Compare
Signed-off-by: ye.sijun <junnplus@gmail.com>
junnplus
force-pushed
the
compose-multi-files
branch
from
af31080
to
a0055ff
Compare
fahedouch
reviewed
Feb 13, 2022
| var dockerComposeYAML = ` | ||
| services: | ||
| hello1: | ||
| image: alpine:3.13 |
There was a problem hiding this comment.
plz use testing predefined image var
nerdctl/pkg/testutil/testutil_linux.go
Line 27 in 251ddce
There was a problem hiding this comment.
@fahedouch Only the config is tested here, and the image will not be pulled. It may be better to explicitly write the image version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ye.sijun junnplus@gmail.com
Fixes: #618