-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ParseEventMask to produce proper masks for 'pod' and 'container' shorthand event notations. #39
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 63.83% 64.00% +0.16%
==========================================
Files 9 9
Lines 1800 1800
==========================================
+ Hits 1149 1152 +3
+ Misses 500 497 -3
Partials 151 151 ☔ View full report in Codecov by Sentry. |
/assign @fuweid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
The fix itself is very valid, but could I ask you to rewrite the commit message to something a bit more descriptive. Maybe something like this:
"""
Fix ParseEventMask
to produce proper masks for 'pod' and 'container' shorthand event notations.
"""
Signed-off-by: ZP-AlwaysWin <zhangpeng63@baidu.com>
@klihub Thanks ! Modified PTAL |
/assign @samuelkarp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ZP-AlwaysWin Do you want zhangpeng as name for change log? |
ok |
the keys in code's bits map is lowercase
so should fix if strings.Contains(name, "Pod") => if strings.Contains(name, "pod")